mirror of
https://github.com/aiogram/aiogram.git
synced 2026-04-08 16:37:47 +00:00
1df3adaba1
* Smaller timeout for MongoStorage connection
By default serverSelectionTimeoutMS=30000. This is too much
* Correct ConnectionError for RedisStorage in tests
* Remove unused import in conftest.py
* Refactor skipping redis and mongo tests
* Fail redis and mongo tests if incorrect URI
If incorrect URIs provided to "--redis" and/or "--mongo" options
tests should fail with ERRORs instead of skipping.
Otherwise the next scenario is possible:
1) developer breaks RedisStorage and/or MongoStorage code
2) tests are run with incorrect redis and/or mongo URIs
provided by "--redis" and "--mongo" options.
For example, wrong port specified.
3) tests pass because skipping doesn't fail tests run
4) developer or reviewer doesn't notice
that redis and/or mongo tests were skipped
5) broken code gets in codebase
* Remove unused fixtures passing in storages tests
* Define create_storage_key fixture in conftest.py
* Linters formatting
* Changes description
* Revert "Smaller timeout for MongoStorage connection"
This reverts commit d88b7ec612.
* Smaller timeout for MongoStorage connection in tests
The default 30s timeout is too long
* Add test for MongoStorage for 100% coverage
* Linters formatting
* Move skipping redis/mongo tests in earlier fixtures
* Replace vars with constants in conftest.py
* Linters formatting
11 lines
690 B
ReStructuredText
11 lines
690 B
ReStructuredText
Fail redis and mongo tests if incorrect URI provided + some storages tests refactoring
|
|
|
|
If incorrect URIs provided to "--redis" and/or "--mongo" options tests should fail with errors instead of skipping.
|
|
Otherwise the next scenario is possible:
|
|
1) developer breaks RedisStorage and/or MongoStorage code
|
|
2) tests are run with incorrect redis and/or mongo URIsprovided by "--redis" and "--mongo" options (for example, wrong port specified)
|
|
3) tests pass because skipping doesn't fail tests run
|
|
4) developer or reviewer doesn't notice that redis and/or mongo tests were skipped
|
|
5) broken code gets in codebase
|
|
|
|
Also some refactorings done (related with storages and storages tests).
|