enh: use tuples instead of lists for some checks

This commit is contained in:
uburuntu 2020-07-27 20:34:27 +03:00
parent 49f50c4d02
commit f6b1c51126
4 changed files with 6 additions and 6 deletions

View file

@ -80,7 +80,7 @@ def check_result(method_name: str, content_type: str, status_code: int, body: st
exceptions.NotFound.detect(description)
elif status_code == HTTPStatus.CONFLICT:
exceptions.ConflictError.detect(description)
elif status_code in [HTTPStatus.UNAUTHORIZED, HTTPStatus.FORBIDDEN]:
elif status_code in (HTTPStatus.UNAUTHORIZED, HTTPStatus.FORBIDDEN):
exceptions.Unauthorized.detect(description)
elif status_code == HTTPStatus.REQUEST_ENTITY_TOO_LARGE:
raise exceptions.NetworkError('File too large for uploading. '

View file

@ -1135,10 +1135,10 @@ class Bot(BaseBot, DataMixin, ContextInstanceMixin):
permissions = prepare_arg(permissions)
payload = generate_payload(**locals())
for permission in ['can_send_messages',
for permission in ('can_send_messages',
'can_send_media_messages',
'can_send_other_messages',
'can_add_web_page_previews']:
'can_add_web_page_previews'):
if permission in payload:
warnings.warn(f"The method `restrict_chat_member` now takes the new user permissions "
f"in a single argument of the type ChatPermissions instead of "

View file

@ -66,8 +66,8 @@ class ChatMemberStatus(helper.Helper):
@classmethod
def is_chat_admin(cls, role: str) -> bool:
return role in [cls.ADMINISTRATOR, cls.CREATOR]
return role in (cls.ADMINISTRATOR, cls.CREATOR)
@classmethod
def is_chat_member(cls, role: str) -> bool:
return role in [cls.MEMBER, cls.ADMINISTRATOR, cls.CREATOR, cls.RESTRICTED]
return role in (cls.MEMBER, cls.ADMINISTRATOR, cls.CREATOR, cls.RESTRICTED)

View file

@ -239,7 +239,7 @@ class MediaGroup(base.TelegramObject):
elif not isinstance(media, InputMedia):
raise TypeError(f"Media must be an instance of InputMedia or dict, not {type(media).__name__}")
elif media.type in ['document', 'audio', 'animation']:
elif media.type in ('document', 'audio', 'animation'):
raise ValueError(f"This type of media is not supported by media groups!")
self.media.append(media)