Address review comments: use fixture and variables in tests, add changelog

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
latand 2026-02-10 10:28:53 +02:00
parent 9acc4413f6
commit c855b2a656
2 changed files with 29 additions and 26 deletions

1
CHANGES/1762.bugfix.rst Normal file
View file

@ -0,0 +1 @@
Fix review issues from Bot API 9.4 PR: fix Makefile reformat scope inconsistency, add ``User.get_profile_audios()`` shortcut method, improve test coverage for ``VideoQuality`` and ``ChatOwnerLeft``.

View file

@ -1,34 +1,42 @@
import pytest
from aiogram.types import Video, VideoQuality
@pytest.fixture()
def video_quality():
return VideoQuality(
file_id="abc123",
file_unique_id="unique123",
width=1920,
height=1080,
codec="h264",
)
class TestVideoQuality:
def test_instantiation(self):
vq = VideoQuality(
file_id="abc123",
file_unique_id="unique123",
width=1920,
height=1080,
codec="h264",
)
assert vq.file_id == "abc123"
assert vq.file_unique_id == "unique123"
assert vq.width == 1920
assert vq.height == 1080
assert vq.codec == "h264"
assert vq.file_size is None
def test_instantiation(self, video_quality: VideoQuality):
assert video_quality.file_id == "abc123"
assert video_quality.file_unique_id == "unique123"
assert video_quality.width == 1920
assert video_quality.height == 1080
assert video_quality.codec == "h264"
assert video_quality.file_size is None
def test_instantiation_with_file_size(self):
file_size = 1048576
vq = VideoQuality(
file_id="abc123",
file_unique_id="unique123",
width=1920,
height=1080,
codec="h265",
file_size=1048576,
file_size=file_size,
)
assert vq.file_size == 1048576
assert vq.file_size == file_size
def test_video_with_qualities(self):
def test_video_with_qualities(self, video_quality: VideoQuality):
file_size = 524288
video = Video(
file_id="video123",
file_unique_id="unique_video123",
@ -36,24 +44,18 @@ class TestVideoQuality:
height=1080,
duration=120,
qualities=[
VideoQuality(
file_id="q1",
file_unique_id="uq1",
width=1920,
height=1080,
codec="h264",
),
video_quality,
VideoQuality(
file_id="q2",
file_unique_id="uq2",
width=1280,
height=720,
codec="h264",
file_size=524288,
file_size=file_size,
),
],
)
assert video.qualities is not None
assert len(video.qualities) == 2
assert video.qualities[0].width == 1920
assert video.qualities[1].file_size == 524288
assert video.qualities[1].file_size == file_size