Fix review issues from PR #1761 (#1762)

* Fix review issues from PR #1761

- Remove stray '-' artifact from GameHighScore docstring
- Fix Makefile reformat target scope inconsistency (ruff check --fix)
- Add User.get_profile_audios() shortcut method (parallel to get_profile_photos)
- Test ChatOwnerLeft with new_owner=None (edge case)
- Add VideoQuality type and Video.qualities nesting tests
- Add User.get_profile_audios() test

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address review comments: use fixture and variables in tests, add changelog

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address review follow-ups for PR #1762

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Kostiantyn Kriuchkov 2026-02-10 23:22:36 +02:00 committed by GitHub
parent ad9c77f99a
commit 06bdae69c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 119 additions and 2 deletions

View file

@ -264,6 +264,13 @@ TEST_MESSAGE_CHAT_OWNER_LEFT = Message(
chat=Chat(id=42, type="private"),
from_user=User(id=42, is_bot=False, first_name="Test"),
)
TEST_MESSAGE_CHAT_OWNER_LEFT_NO_SUCCESSOR = Message(
message_id=42,
date=datetime.datetime.now(),
chat_owner_left=ChatOwnerLeft(),
chat=Chat(id=42, type="private"),
from_user=User(id=42, is_bot=False, first_name="Test"),
)
TEST_MESSAGE_CHAT_OWNER_CHANGED = Message(
message_id=42,
date=datetime.datetime.now(),
@ -1047,6 +1054,12 @@ class TestMessage:
def test_content_type(self, message: Message, content_type: str):
assert message.content_type == content_type
def test_chat_owner_left_no_successor(self):
assert (
TEST_MESSAGE_CHAT_OWNER_LEFT_NO_SUCCESSOR.content_type
== ContentType.CHAT_OWNER_LEFT
)
def test_as_reply_parameters(self):
message = Message(
message_id=42, chat=Chat(id=42, type="private"), date=datetime.datetime.now()

View file

@ -56,3 +56,9 @@ class TestUser:
method = user.get_profile_photos(description="test")
assert method.user_id == user.id
def test_get_profile_audios(self):
user = User(id=42, is_bot=False, first_name="Test", last_name="User")
method = user.get_profile_audios(description="test")
assert method.user_id == user.id

View file

@ -0,0 +1,61 @@
import pytest
from aiogram.types import Video, VideoQuality
@pytest.fixture()
def video_quality():
return VideoQuality(
file_id="abc123",
file_unique_id="unique123",
width=1920,
height=1080,
codec="h264",
)
class TestVideoQuality:
def test_instantiation(self, video_quality: VideoQuality):
assert video_quality.file_id == "abc123"
assert video_quality.file_unique_id == "unique123"
assert video_quality.width == 1920
assert video_quality.height == 1080
assert video_quality.codec == "h264"
assert video_quality.file_size is None
def test_instantiation_with_file_size(self):
file_size = 1048576
vq = VideoQuality(
file_id="abc123",
file_unique_id="unique123",
width=1920,
height=1080,
codec="h265",
file_size=file_size,
)
assert vq.file_size == file_size
def test_video_with_qualities(self, video_quality: VideoQuality):
file_size = 524288
video = Video(
file_id="video123",
file_unique_id="unique_video123",
width=1920,
height=1080,
duration=120,
qualities=[
video_quality,
VideoQuality(
file_id="q2",
file_unique_id="uq2",
width=1280,
height=720,
codec="h264",
file_size=file_size,
),
],
)
assert video.qualities is not None
assert len(video.qualities) == 2
assert video.qualities[0].width == 1920
assert video.qualities[1].file_size == file_size